Re: [PATCH] Input: goodix - decouple irq and reset lines

From: Gonzalez, Alex
Date: Mon Jan 07 2019 - 11:42:36 EST

Hi Bastien,

>Given that we do have access to the datasheet, it would also be useful
>for the patch to mention where in the datasheet it says that the reset
>line can be left pulled-up,

The pin description table on section 4, on the "Reset pin" row, contains a
remark as follows:

External 10K pull-up resistor required, active-low reset

This comes from a newer revision of the datasheet though:

I guess it's open to interpretation whether driving the reset line is
optional. The code seemed to imply it by using devm_gpiod_get_optional() to
obtain the GPIO.

>or mention on which shipping device this
>setup is already used (and if so, what the DTS or ACPI snippet that
>declares those is).

I am testing with an LCD application kit for the ConnectCore 6UL SBC Pro:

This display in particular does not have the reset line available on the
connector. The only way to make it work seems to be to use the INT line to fix
an I2C address.