Re: [PATCH] scsi: sd: Make protection lookup tables static

From: Bart Van Assche
Date: Mon Jan 07 2019 - 11:57:29 EST

On Mon, 2019-01-07 at 22:41 +-0800, John Garry wrote:
+AD4 Currently the protection lookup tables in sd+AF8-prot+AF8-flag+AF8-mask() and
+AD4 sd+AF8-prot+AF8-op() are declared non-static. As such, they will be rebuilt for
+AD4 each respective function call.
+AD4 Optimise by making them static.
+AD4 This saves +AH4-100B object code for sd.c:
+AD4 Before:
+AD4 text data bss dec hex filename
+AD4 25403 1024 16 26443 674b drivers/scsi/sd.o
+AD4 After:
+AD4 text data bss dec hex filename
+AD4 25299 1024 16 26339 66e3 drivers/scsi/sd.o

Since the sd+AF8-prot+AF8-op() function only has a single caller, please move it from sd.h
into sd.c.