Re: [PATCH net v3 1/4] umh: add exit routine for UMH process

[Taehee Yoo]

On Tue, 8 Jan 2019 at 00:25, David Miller <davem@xxxxxxxxxxxxx> wrote:
>
> From: Taehee Yoo <ap420073@xxxxxxxxx>
> Date: Mon,  7 Jan 2019 21:10:14 +0900
>
> > @@ -679,6 +688,29 @@ static int proc_cap_handler(struct ctl_table *table, int write,
> >       return 0;
> >  }
> >
> > +void exit_umh(struct task_struct *tsk)
> > +{
> > +     struct umh_info *info;
> > +     pid_t pid = tsk->pid;
> > +
> > +     if (!(tsk->flags & PF_UMH))
> > +             return;
>
> Let's really make this low cost.
>
> In linux/sched.h or similar:
>
> void __exit_umh(struct task_struct *tsk);
>
> static inline void exit_umh(struct task_struct *tsk)
> {
>         if (unlikely(tsk->flags & PF_UMH))
>                 __exit_umh(tsk);
> }
>
> Thank you.

Thanks a lot for the review!

I will send a v4 patch.