Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

[Dan Murphy]

Vesa

On 1/4/19 6:39 PM, Vesa JÃÃskelÃinen wrote:
> Hi Jacek,
> 
> On 04/01/2019 23.37, Jacek Anaszewski wrote:
>> But, aside from that hypothetic issue, we need a solution for
>> LEDn_BRIGHTNESS feature of lp5024, i.e. setting color intensity
>> via a single register write. How would you propose to address that?
> 
> You could model it to something like this in device tree:
> 
> led-module @ <i2c-address> {
> ÂÂÂÂcompatible = "lp5024";
> 
> ÂÂÂÂ// There is in hardware setup to use either linear or
> ÂÂÂÂ// logarithmic scaling:
> ÂÂÂÂ//enable-logarithmic-brightness;
> 
> ÂÂÂÂled0 {
> ÂÂÂÂÂÂÂ // this will create led instance for LED0 in lp5024
> ÂÂÂÂÂÂÂ label = "lp-led0";
> ÂÂÂÂÂÂÂ
> ÂÂÂÂÂÂÂ // This specifies LED number within lp5024
> ÂÂÂÂÂÂÂ led-index = <0>;ÂÂ // set output-base as 0*3 == 0
> ÂÂÂÂÂÂÂ
> ÂÂÂÂÂÂÂ element-red {
> ÂÂÂÂÂÂÂÂÂÂÂ // refers to OUT0
> ÂÂÂÂÂÂÂÂÂÂÂ output-offset = <0>;
> ÂÂÂÂÂÂÂ };
> ÂÂÂÂÂÂÂ
> ÂÂÂÂÂÂÂ element-green {
> ÂÂÂÂÂÂÂÂÂÂÂ // refers to OUT1
> ÂÂÂÂÂÂÂÂÂÂÂ output-offset = <1>;
> ÂÂÂÂÂÂÂ };
> ÂÂÂÂÂÂÂ
> ÂÂÂÂÂÂÂ element-blue {
> ÂÂÂÂÂÂÂÂÂÂÂ // refers to OUT2
> ÂÂÂÂÂÂÂÂÂÂÂ output-offset = <2>;
> ÂÂÂÂÂÂÂ };
> ÂÂÂÂÂÂÂ
> ÂÂÂÂ};ÂÂÂ
> 
> ÂÂÂÂled1 {
> ÂÂÂÂÂÂÂ // this will create led instance for LED1 in lp5024
> ÂÂÂÂÂÂÂ label = "lp-led1";
> ÂÂÂÂÂÂÂ
> ÂÂÂÂÂÂÂ // This specifies LED number within lp5024
> ÂÂÂÂÂÂÂ led-index = <1>;ÂÂ // set output-base as 1*3 == 3
> 

Can we not use led-sources like I have done already?
I really like to keep the DT nodes simple and re-use nodes that exist if possible.

My code already maps and groups the outputs into the associated banks

Dan
<snip>

-- 
------------------
Dan Murphy