Re: [PATCH v3] coding-style: Clarify the expectations around bool
From: Jason Gunthorpe
Date: Mon Jan 07 2019 - 18:25:18 EST
On Mon, Jan 07, 2019 at 02:10:22PM -0800, Joe Perches wrote:
> On Mon, 2019-01-07 at 14:11 -0700, Jason Gunthorpe wrote:
> > There has been some confusion since checkpatch started warning about bool
> > use in structures, and people have been avoiding using it.
> > Many people feel there is still a legitimate place for bool in structures,
> > so provide some guidance on bool usage derived from the entire thread that
> > spawned the checkpatch warning.
> Thanks Jason.
> It'd be nice to combine this with some better checkpatch warning or
> even a removal of that misleading warning from checkpatch
Okay, do you have a preference?
> With a couple minor nits below and and Ack if
> you want one:
> Acked-by: Joe Perches <joe@xxxxxxxxxxx>
Thanks, I made the revisions with Bart's extra words. I'll send a v4
in a few days.