Re: [PATCH] kernel/sys.c: Fix UNAME26 for 5.0

[Jonathan NeuschÃfer]

On Mon, Jan 07, 2019 at 10:10:31AM -0800, Linus Torvalds wrote:
> On Mon, Jan 7, 2019 at 10:03 AM Jonathan NeuschÃfer
> <j.neuschaefer@xxxxxxx> wrote:
> >
> > UNAME26 is a mechanism to report Linux's version as 2.6.x, for
> > compatibility with old/broken software. Because of the way it is
> > implemented, it needs to be adjusted to handle version 5.0.
> 
> Do we actually need this?

I don't run any such old software, so I don't have a strong opinion
here; I just sent this patch because I knew UNAME26 version strings
would jump back without it.

> I'd rather let it bitrot, and just let it return random versions. It
> will just start again at 2.4.60, won't it?

Correct.
(Well, it's 2.6, not 2.4, but yes)

> Anybody who uses UNAME26 for a 5.x kernel might as well think it's
> still 4.x. The user space is so old that it can't possibly care about
> differences between 4.x and 5.x, can it?
> 
> The only thing that matters is that it shows "2.4.<largeenough>",
> which it will do regardless.

Good point, I guess that's a valid appraoch.



Jonathan NeuschÃfer

Attachment: signature.asc
Description: PGP signature