Re: [PATCH] samples/seccomp: fix 32-bit build

From: Ingo Molnar
Date: Tue Jan 08 2019 - 01:43:56 EST



* Kees Cook <keescook@xxxxxxxxxxxx> wrote:

> On Mon, Jan 7, 2019 at 3:16 PM Tycho Andersen <tycho@xxxxxxxx> wrote:
> >
> > Both the .o and the actual executable need to be built with -m32 in order
> > to link correctly.
> >
> > Signed-off-by: Tycho Andersen <tycho@xxxxxxxx>
> > Reported-by: Ingo Molnar <mingo@xxxxxxxxxx>
> > Fixes: fec7b6690541 ("samples: add an example of seccomp user trap")
>
> Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
>
> > ---
> > I guess x86 can pick this up directly? Not sure where it should go
> > exactly.
>
> Ingo, can you snag this? (It's a more direct path, otherwise I can
> take it via seccomp, which will go through my tree then James's
> tree...)

Sure - applied it to x86/urgent.

Thanks,

Ingo