Re: [PATCH v6 07/11] drivers: thermal: int3406_thermal: Make PCI dependency explicit

[Sinan Kaya]

On Tue, Jan 8, 2019 at 6:58 AM Zhang Rui <rui.zhang@xxxxxxxxx> wrote:
>
> On ä, 2019-01-07 at 12:19 +0100, Rafael J. Wysocki wrote:
> > On Sat, Jan 5, 2019 at 11:06 AM Sinan Kaya <okaya@xxxxxxxxxx> wrote:
> > >
> > >
> > > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built
> > > without
> > > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> > > satisfied implicitly through dependencies on CONFIG_ACPI have to be
> > > specified directly. Need CONFIG_PCI to be set in order to be able
> > > to use
> > > this driver.
> > >
> > > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without
> > > CONFIG_PCI set")
> > > Signed-off-by: Sinan Kaya <okaya@xxxxxxxxxx>
> > > ---
> > >  drivers/thermal/intel/int340x_thermal/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig
> > > b/drivers/thermal/intel/int340x_thermal/Kconfig
> > > index 0582bd12a239..fba1976d5f8d 100644
> > > --- a/drivers/thermal/intel/int340x_thermal/Kconfig
> > > +++ b/drivers/thermal/intel/int340x_thermal/Kconfig
> > > @@ -31,7 +31,7 @@ if INT340X_THERMAL
> > >
> > >  config INT3406_THERMAL
> > >         tristate "ACPI INT3406 display thermal driver"
> > > -       depends on ACPI_VIDEO
> > > +       depends on ACPI_VIDEO && PCI
> > >         help
> > >           The display thermal device represents the LED/LCD display
> > > panel
> > >           that may or may not include touch support. The main
> > > function of
> > > --
> > Rui, any objections here?  And for the [11/11]?
>
> CONFIG_INT3406_THERMAL depends on CONFIG_INT340X_THERMAL, so IMO, patch
> 11 is sufficient.

Yes, we can drop this patch. I found the issues in reverse order. Can
we get an ACK for 11/11?

>
> thanks,
> rui