Re: [PATCH v3 0/2] perf tests: Check for ARM [vectors] page
From: Arnaldo Carvalho de Melo
Date: Tue Jan 08 2019 - 08:23:31 EST
Em Tue, Jan 01, 2019 at 06:39:26PM +0100, Jiri Olsa escreveu:
> On Thu, Dec 20, 2018 at 07:43:35PM -0800, Florian Fainelli wrote:
> > I just painfully learned that perf would segfault when
> > CONFIG_KUSER_HELPERS is disabled because it unconditionally makes use of
> > it. This patch series adds an ARM test for that by leveraging the
> > existing find_vdso_map() function and making it more generic and capable
> > of location any map within /proc/self/maps.
> >
> > Changes in v3:
> >
> > - remove find_vdso_map() call find_map() with VDSO__MAP_NAME
> >
> > Changes in v2:
> >
> > - use strlen() instead of sizeof() -1 since we made the page name a
> > parameter
> > - use TEST_OK/TEST_FAIL in lieu of 0/-1
> > - added an error message indicating CONFIG_KUSER_HELPERS might be
> > disabled
> >
> > Florian Fainelli (2):
> > perf tools: Make find_vdso_map() more modular
> > perf tests: Add a test for the ARM 32-bit [vectors] page
>
> Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>
Thanks, applied.
- Arnaldo