Re: [PATCH v4 1/2] kobject: use pr_warn to replace printk

[Rafael J. Wysocki]

On Tue, Jan 8, 2019 at 1:54 PM YU Bo <tsu.yubo@xxxxxxxxx> wrote:
>
> Hi,
> On Tue, Jan 08, 2019 at 10:39:57AM +0100, Rafael J. Wysocki wrote:
> >On Tue, Jan 8, 2019 at 4:11 AM Bo YU <tsu.yubo@xxxxxxxxx> wrote:
> >>
> >> This is a fix to replace printk with pr_warn
> >
> >You call it a "fix", but what exactly is wrong with the code as is?
> Is there any differentions between pr_* and printk?
> If they were the same with functionial, i think it  would be better
> to use pr_* to replace printk.There are two lines code with printk only
> and others are pr_* in kobject_uevent.c.
> In fact,as you know, the code is fine.I just want to keep consistency with
> looks like

OK, so please don't call it a "fix" as doing so suggests a functional
defect in the current code that is addressed by your patch which is
not the case.

You can write something like

"Replace printk() with pr_warn() in kobject_synth_uevent() to make it
consistent with the other code in kobject_uevent.c."

in the changelog which would be clear enough IMO.