Re: [PATCH v2 0/2] Revamp admin-guide/tainted-kernels.rst to make it more comprehensible

[Thorsten Leemhuis]

Jonathan Corbet schrieb am 09.01.19 um 00:47:
> On Tue,  8 Jan 2019 20:40:05 +0100
> Thorsten Leemhuis <linux@xxxxxxxxxxxxx> wrote:
>
> OK, so we're so close...  I think the patches are good; they are a welcome
> improvement to the documentation and the script looks great.  Thanks for
> doing this!

More to come, but the revamp for reporting-bugs.rst that I started
already will take a little bit longer to get done, as there is much
ground to cover... (and there are three Linux conferences ahead for me
in the next few weeks, too)

>  Patches applied.

thx

> Now for the "I love your patch, something to improve part" :)
>  - Patch 1 didn't apply to docs-next; probably you got caught by the
>    fast-forward to 5.0-rc1.  I've applied it to 4.20 then merged to
>    resolve the conflict in tools/Makefile.

Ugh, sorry, rechecking was on my mental todo list, but fell through the
cracks

>  - I was tempted to ask you to redo the changelogs, but ended up just
>    tweaking them myself.

Thx.

> Changelogs should focus on what the patch does
>    and why; they aren't usually the place for the history of how the patch
>    came to exist in its current form. 

Looks like I got carried away a little bit :-/

> I'll append what actually got
>    committed.  (Filling to 72 columns or so is also a nice touch for
>    changelogs).

Ohh, I thought it was 80. *makesnote*

> [...]

Ciao, Thorsten