Re: [PATCH 4.14 000/101] 4.14.92-stable review

[Greg Kroah-Hartman]

On Wed, Jan 09, 2019 at 12:40:11PM +0100, Jinpu Wang wrote:
> Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> ä2019å1æ8æåä äå1:28åéï
> >
> > On Mon, Jan 07, 2019 at 08:59:12PM -0800, Guenter Roeck wrote:
> >
> > Should all now be fixed up.
> >
> > I hope, this set of releases has been a pain...
> >
> > greg k-h
> 
> I had build failure below, looks related to 0fe69354b888 ("crypto:
> testmgr - add AES-CFB tests")
> In file included from crypto/testmgr.c:54:0:
> crypto/testmgr.h:16039:3: error: unknown field 'ptext' specified in initializer
>    .ptext = "\x6b\xc1\xbe\xe2\x2e\x40\x9f\x96"
>    ^
> crypto/testmgr.h:16047:3: error: unknown field 'ctext' specified in initializer
>    .ctext = "\x3b\x3f\xd9\x2e\xb7\x2d\xad\x20"
>    ^
> crypto/testmgr.h:16055:3: error: unknown field 'len' specified in initializer
>    .len = 64,
>    ^
> crypto/testmgr.h:16055:3: warning: initialization makes pointer from
> integer without a cast
> crypto/testmgr.h:16055:3: warning: (near initialization for
> 'aes_cfb_tv_template[0].result')
> crypto/testmgr.h:16063:3: error: unknown field 'ptext' specified in initializer
>    .ptext = "\x6b\xc1\xbe\xe2\x2e\x40\x9f\x96"
>    ^
> crypto/testmgr.h:16071:3: error: unknown field 'ctext' specified in initializer
>    .ctext = "\xcd\xc8\x0d\x6f\xdd\xf1\x8c\xab"
>    ^
> crypto/testmgr.h:16079:3: error: unknown field 'len' specified in initializer
>    .len = 64,
>    ^
> crypto/testmgr.h:16079:3: warning: initialization makes pointer from
> integer without a cast
> crypto/testmgr.h:16079:3: warning: (near initialization for
> 'aes_cfb_tv_template[1].result')
> crypto/testmgr.h:16088:3: error: unknown field 'ptext' specified in initializer
>    .ptext = "\x6b\xc1\xbe\xe2\x2e\x40\x9f\x96"
>    ^
> crypto/testmgr.h:16096:3: error: unknown field 'ctext' specified in initializer
>    .ctext = "\xdc\x7e\x84\xbf\xda\x79\x16\x4b"
>    ^
> crypto/testmgr.h:16104:3: error: unknown field 'len' specified in initializer
>    .len = 64,
>    ^
> crypto/testmgr.h:16104:3: warning: initialization makes pointer from
> integer without a cast
> crypto/testmgr.h:16104:3: warning: (near initialization for
> 'aes_cfb_tv_template[2].result')
>   CC [M]  drivers/infiniband/sw/rxe/rxe_hw_counters.o
>   CC      drivers/pci/pcie/portdrv_bus.o
>   CC      lib/devres.o
> crypto/testmgr.c:2633:4: error: unknown field 'vecs' specified in initializer
>     .cipher = __VECS(aes_cfb_tv_template)
>     ^
> crypto/testmgr.c:2633:4: warning: missing braces around initializer
> [-Wmissing-braces]
> crypto/testmgr.c:2633:4: warning: (near initialization for
> 'alg_test_descs[36].suite.cipher.enc') [-Wmissing-braces]
> crypto/testmgr.c:2633:4: error: unknown field 'count' specified in initializer
> In file included from ./include/linux/kernel.h:15:0,
>                  from ./include/linux/crypto.h:21,
>                  from ./include/crypto/aead.h:16,
>                  from crypto/testmgr.c:23:
> ./include/linux/build_bug.h:30:45: warning: initialization makes
> pointer from integer without a cast
>  #define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:(-!!(e)); }))
>                                              ^
> ./include/linux/compiler-gcc.h:65:28: note: in expansion of macro
> 'BUILD_BUG_ON_ZERO'
>  #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0]))
>                             ^
> ./include/linux/kernel.h:71:59: note: in expansion of macro '__must_be_array'
>  #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
>                                                            ^
> crypto/testmgr.c:2347:43: note: in expansion of macro 'ARRAY_SIZE'
>  #define __VECS(tv) { .vecs = tv, .count = ARRAY_SIZE(tv) }
>                                            ^
> crypto/testmgr.c:2633:14: note: in expansion of macro '__VECS'
>     .cipher = __VECS(aes_cfb_tv_template)
>               ^
> ./include/linux/build_bug.h:30:45: warning: (near initialization for
> 'alg_test_descs[36].suite.cipher.dec.vecs')
>  #define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:(-!!(e)); }))
>                                              ^
> ./include/linux/compiler-gcc.h:65:28: note: in expansion of macro
> 'BUILD_BUG_ON_ZERO'
>  #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0]))
>                             ^
> ./include/linux/kernel.h:71:59: note: in expansion of macro '__must_be_array'
>  #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
>                                                            ^
> crypto/testmgr.c:2347:43: note: in expansion of macro 'ARRAY_SIZE'
>  #define __VECS(tv) { .vecs = tv, .count = ARRAY_SIZE(tv) }
>                                            ^
> crypto/testmgr.c:2633:14: note: in expansion of macro '__VECS'
>     .cipher = __VECS(aes_cfb_tv_template)
>               ^
>   CC [M]  drivers/md/dm-snap.o
> scripts/Makefile.build:326: recipe for target 'crypto/testmgr.o' failed
> make[4]: *** [crypto/testmgr.o] Error 1
> Makefile:1045: recipe for target 'crypto' failed
> make[3]: *** [crypto] Error 2

You are right, that totally does not build.  Odd that no one else's
tests caught this :(

Anyway, thanks for this, I've dropped the patch from 4.14.y now.

greg k-h