Re: [PATCH v15 04/11] livepatch: Don't block the removal of patches loaded after a forced transition

[Miroslav Benes]

On Wed, 9 Jan 2019, Petr Mladek wrote:

> module_put() is currently never called in klp_complete_transition() when
> klp_force is set. As a result, we might keep the reference count even when
> klp_enable_patch() fails and klp_cancel_transition() is called.
> 
> This might give the impression that a module might get blocked in some
> strange init state. Fortunately, it is not the case. The reference count
> is ignored when mod->init fails and erroneous modules are always removed.
> 
> Anyway, this might be confusing. Instead, this patch moves
> the global klp_forced flag into struct klp_patch. As a result,
> we block only modules that might still be in use after a forced
> transition. Newly loaded livepatches might be eventually completely
> removed later.
> 
> It is not a big deal. But the code is at least consistent with
> the reality.
> 
> Signed-off-by: Petr Mladek <pmladek@xxxxxxxx>
> Acked-by: Joe Lawrence <joe.lawrence@xxxxxxxxxx>

Acked-by: Miroslav Benes <mbenes@xxxxxxx>

Miroslav