Re: [PATCH v3 4/9] ASoC: sun4i-i2s: Fix offset mask

From: Mark Brown
Date: Wed Jan 09 2019 - 13:51:06 EST


On Sat, Dec 22, 2018 at 12:54:48AM +0800, Chen-Yu Tsai wrote:
> On Fri, Dec 21, 2018 at 11:21 PM <codekipper@xxxxxxxxx> wrote:

> > Also add offset to RX channel select

> Commit log seems a bit lacking. You could probably explain how you
> found this, either when comparing datasheet macros, or some actual
> error manifested and you "heard" it. You could also state what the
> fixed outcome should be.

> Also please add a fixes tag.

Plus send this at the start of the series so it can be applied as a fix
and sent to Linus during the development cycle.

Attachment: signature.asc
Description: PGP signature