Re: [PATCH v6 0/5] spi: spi-mem: Add driver for NXP FlexSPI controller

[Lukasz Majewski]

Hi Frieder,

> Hi Lukasz,
> 
> On 09.01.19 15:56, Lukasz Majewski wrote:
> > Hi Schrempf,
> >   
> >> On 08.01.19 10:24, Yogesh Narayan Gaur wrote:  
> >>> - Add driver for NXP FlexSPI host controller
> >>>
> >>>    FlexSPI is a flexsible SPI host controller [1], Chapter 30 page
> >>> 1475, which supports two SPI channels and up to 4 external
> >>> devices. Each channel supports Single/Dual/Quad/Octal mode data
> >>> transfer (1/2/4/8 bidirectional data lines) i.e. FlexSPI acts as
> >>> an interface to external devices, maximum 4, each with up to 8
> >>> bidirectional data lines.
> >>>
> >>> - Tested this driver with mtd_debug(Erase/Write/Read) utility and
> >>> JFFS2 filesystem mounting and booting on NXP LX2160ARDB[2] and
> >>> LX2160AQDS targets. LX2160ARDB is having two NOR slave device
> >>> connected on single bus A i.e. A0 and A1 (CS0 and CS1).
> >>>    LX2160AQDS is having two NOR slave device connected on separate
> >>> buses one flash on A0 and second on B1 i.e. (CS0 and CS3).
> >>>    Verified this driver on following SPI NOR flashes:
> >>>      Micron, mt35xu512aba, [Read - 1 bit mode]
> >>>      Cypress, s25fl512s, [Read - 1/2/4 bit mode]
> >>>
> >>> [1] https://www.nxp.com/docs/en/reference-manual/IMXRT1050RM.pdf
> >>> [2]
> >>> https://patchwork.kernel.org/project/linux-arm-kernel/list/?submitter=182097
> >>>
> >>> Yogesh Narayan Gaur (5):
> >>>     spi: spi-mem: Add driver for NXP FlexSPI controller
> >>>     dt-bindings: spi: add binding file for NXP FlexSPI controller
> >>>     arm64: dts: lx2160a: add FlexSPI node property
> >>>     arm64: defconfig: enable NXP FlexSPI driver
> >>>     MAINTAINERS: add maintainers for the NXP FlexSPI driver
> >>>
> >>> Changes for v6:
> >>> - Rebase on top of v5.0-rc1.  
> >>
> >> Your patches don't apply to v5.0-rc1. It seems like you have
> >> instead rebased onto the for-5.1 or for-next branch of the SPI
> >> tree. I guess this is okay, but you should have pointed that out
> >> correctly here.  
> > 
> > If I may ask for a few (1-2) days, so I can test this code on vf610
> > NXP SoC.
> > 
> > As fair as I remember there were some issues when I tested it a few
> > months back.  
> 
> You're probably mixing that up. This series is about the FlexSPI 
> controller in the Layerscape SOCs.

Thanks for the explanation - I've indeed mixed up things a bit :-).

I was of course thinking about the QuadSPI driver - as in [1].

> 
> The QuadSPI driver is already in linux-next to be merged in 5.1 [1].
> The issues with vf610 existed in the old SPI-NOR driver and probably
> still exist in the new SPI driver. You are welcome to test the new
> driver and come up with some fixes.

I've posted some questions on NXP community, but no reply so far. 

> 
> Sooner or later, there will probably also be other changes coming up, 
> such as implementation of the dirmap API.
> 
> Thanks,
> Frieder
> 
> [1]: 
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/spi?h=next-20190109&id=84d043185dbe0d1b4f6db575bd91c834d37e2f78
> 
> >   
> >>  
> >>> - Incorporated review comments for
> >>>     patch 'spi: spi-mem: Add driver for NXP FlexSPI controller'.
> >>> - Updated s-b tag in all patches.
> >>> Changes for v5:
> >>> - Rebase on top of v4.20-rc2
> >>> - Incorporated review comments for
> >>>     patch 'spi: spi-mem: Add driver for NXP FlexSPI controller'.
> >>> Changes for v4:
> >>> - Incorporated review comments for
> >>>     patch 'spi: spi-mem: Add driver for NXP FlexSPI controller'.
> >>> - Incorporated binding file review comments.
> >>> Changes for v3:
> >>> - Incorporated review comments for
> >>>     patch 'spi: spi-mem: Add driver for NXP FlexSPI controller'.
> >>> Changes for v2:
> >>> - Incorporated Boris review comments and drop below patches as per
> >>> the comments.
> >>>    - Patch 'spi: add slave device size in spi_device struct'
> >>>    - Patch 'spi: add flags for octal I/O data transfer'
> >>> - Incorporated DTS and Binding file review comments of Shawn Guo
> >>> and Rob Herring.
> >>>
> >>>    .../devicetree/bindings/spi/spi-nxp-fspi.txt  |   39 +
> >>>    MAINTAINERS                                   |    7 +
> >>>    .../boot/dts/freescale/fsl-lx2160a-rdb.dts    |   22 +
> >>>    .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi |   13 +
> >>>    arch/arm64/configs/defconfig                  |    1 +
> >>>    drivers/spi/Kconfig                           |   10 +
> >>>    drivers/spi/Makefile                          |    1 +
> >>>    drivers/spi/spi-nxp-fspi.c                    | 1095
> >>> +++++++++++++++++ 8 files changed, 1188 insertions(+)
> >>>    create mode 100644
> >>> Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt create mode
> >>> 100644 drivers/spi/spi-nxp-fspi.c  
> >> ______________________________________________________
> >> Linux MTD discussion mailing list
> >> http://lists.infradead.org/mailman/listinfo/linux-mtd/  
> > 
> > 
> > 
> > 
> > Best regards,
> > 
> > Lukasz Majewski
> > 
> > --
> > 
> > DENX Software Engineering GmbH,      Managing Director: Wolfgang
> > Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> > Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> > lukma@xxxxxxx 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@xxxxxxx

Attachment: pgpB5Ocujf2Rb.pgp
Description: OpenPGP digital signature