Re: [PATCH] MIPS: jazz: fix 64bit build

From: Paul Burton
Date: Wed Jan 09 2019 - 17:19:17 EST


Hello,

Thomas Bogendoerfer wrote:
> 64bit JAZZ builds failed with
>
> linux-next/arch/mips/jazz/jazzdma.c: In function ÃÂÂvdma_initÃÂÂ:
> /linux-next/arch/mips/jazz/jazzdma.c:77:30: error: implicit declaration of function ÃÂÂKSEG1ADDRÃÂÂ; did you mean ÃÂÂCKSEG1ADDRÃÂÂ? [-Werror=implicit-function-declaration]
> pgtbl = (VDMA_PGTBL_ENTRY *)KSEG1ADDR(pgtbl);
> ^~~~~~~~~
> CKSEG1ADDR
> /linux-next/arch/mips/jazz/jazzdma.c:77:10: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
> pgtbl = (VDMA_PGTBL_ENTRY *)KSEG1ADDR(pgtbl);
> ^
> In file included from /linux-next/arch/mips/include/asm/barrier.h:11:0,
> from /linux-next/include/linux/compiler.h:248,
> from /linux-next/include/linux/kernel.h:10,
> from /linux-next/arch/mips/jazz/jazzdma.c:11:
> /linux-next/arch/mips/include/asm/addrspace.h:41:29: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
> #define _ACAST32_ (_ATYPE_)(_ATYPE32_) /* widen if necessary */
> ^
> /linux-next/arch/mips/include/asm/addrspace.h:53:25: note: in expansion of macro ÃÂÂ_ACAST32_ÃÂÂ
> #define CPHYSADDR(a) ((_ACAST32_(a)) & 0x1fffffff)
> ^~~~~~~~~
> /linux-next/arch/mips/jazz/jazzdma.c:84:44: note: in expansion of macro ÃÂÂCPHYSADDRÃÂÂ
> r4030_write_reg32(JAZZ_R4030_TRSTBL_BASE, CPHYSADDR(pgtbl));
>
> Using correct casts and CKSEG1ADDR when dealing with the pgtbl setup
> fixes this.
>
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@xxxxxxx>

Applied to mips-fixes.

Thanks,
Paul

[ This message was auto-generated; if you believe anything is incorrect
then please email paul.burton@xxxxxxxx to report it. ]