Re: [PATCH] drivers/usb/storage/jumpshot.c: Remove duplicate header

[Oliver Neukum]

On Do, 2019-01-10 at 13:03 +0530, Sabyasachi Gupta wrote:
> Remove unusual_jumpshot.h which is included more than once.
> 
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@xxxxxxxxx>
> ---
>  drivers/usb/storage/jumpshot.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/storage/jumpshot.c b/drivers/usb/storage/jumpshot.c
> index 917f170..06e46c6 100644
> --- a/drivers/usb/storage/jumpshot.c
> +++ b/drivers/usb/storage/jumpshot.c
> @@ -84,7 +84,6 @@ MODULE_DEVICE_TABLE(usb, jumpshot_usb_ids);
>  }
>  
>  static struct us_unusual_dev jumpshot_unusual_dev_list[] = {
> -#	include "unusual_jumpshot.h"
>  	{ }		/* Terminating entry */
>  };
>  

NACK.

It is included twice because the same device needs to be specified
and is quirky. You are breaking the driver.

	Regards
		Oliver