Re: [PATCH 38/41] scsi: sym53c8xx_2: sym_hipd: mark expected switch fall-throughs

[Gustavo A. R. Silva]

Hi,

Friendly ping (second one):

Who can ack/review/take this patch, please?

Thanks
--
Gustavo

On 12/19/18 6:08 PM, Gustavo A. R. Silva wrote:
> Hi,
>
> Friendly ping:
>
> Who can ack or review this patch, please?
>
> Thanks
> --
> Gustavo
>
> On 11/27/18 10:34 PM, Gustavo A. R. Silva wrote:
> > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > where we are expecting to fall through.
> >
> > Addresses-Coverity-ID: 114996 ("Missing break in switch")
> > Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> > ---
> > Â drivers/scsi/sym53c8xx_2/sym_hipd.c | 2 ++
> > Â 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/scsi/sym53c8xx_2/sym_hipd.c b/drivers/scsi/sym53c8xx_2/sym_hipd.c
> > index 0a2a54517b15..054fb0599263 100644
> > --- a/drivers/scsi/sym53c8xx_2/sym_hipd.c
> > +++ b/drivers/scsi/sym53c8xx_2/sym_hipd.c
> > @@ -3072,6 +3072,7 @@ static void sym_sir_bad_scsi_status(struct sym_hcb *np, int num, struct sym_ccb
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂ sym_print_addr(cp->cmd, "%s\n",
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ s_status == S_BUSY ? "BUSY" : "QUEUE FULL\n");
> > ÂÂÂÂÂÂÂÂÂ }
> > +ÂÂÂÂÂÂÂ /* fall through */
> > ÂÂÂÂÂ default:ÂÂÂ /* S_INT, S_INT_COND_MET, S_CONFLICT */
> > ÂÂÂÂÂÂÂÂÂ sym_complete_error (np, cp);
> > ÂÂÂÂÂÂÂÂÂ break;
> > @@ -4632,6 +4633,7 @@ static void sym_int_sir(struct sym_hcb *np)
> > ÂÂÂÂÂÂ *Â Negotiation failed.
> > ÂÂÂÂÂÂ *Â Target does not want answer message.
> > ÂÂÂÂÂÂ */
> > +ÂÂÂ /* fall through */
> > ÂÂÂÂÂ case SIR_NEGO_PROTO:
> > ÂÂÂÂÂÂÂÂÂ sym_nego_default(np, tp, cp);
> > ÂÂÂÂÂÂÂÂÂ goto out;