Re: [PATCH 34/41] scsi: osst: mark expected switch fall-throughs

[Gustavo A. R. Silva]

Hi,

Friendly ping (second one):

Who can ack/review/take this patch, please?

Thanks
--
Gustavo

On 12/19/18 6:07 PM, Gustavo A. R. Silva wrote:
> Hi,
>
> Friendly ping:
>
> Who can ack or review this patch, please?
>
> Thanks
> --
> Gustavo
>
> On 11/27/18 10:33 PM, Gustavo A. R. Silva wrote:
> > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > where we are expecting to fall through.
> >
> > Addresses-Coverity-ID: 114983 ("Missing break in switch")
> > Addresses-Coverity-ID: 114984 ("Missing break in switch")
> > Addresses-Coverity-ID: 114985 ("Missing break in switch")
> > Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> > ---
> > Â drivers/scsi/osst.c | 6 ++++++
> > Â 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c
> > index 664c1238a87f..7e877b43785d 100644
> > --- a/drivers/scsi/osst.c
> > +++ b/drivers/scsi/osst.c
> > @@ -216,12 +216,14 @@ static void osst_analyze_sense(struct osst_request *SRpnt, struct st_cmdstatus *
> > ÂÂÂÂÂÂÂÂÂ switch (sense[0] & 0x7f) {
> > ÂÂÂÂÂÂÂÂÂ case 0x71:
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂ s->deferred = 1;
> > +ÂÂÂÂÂÂÂÂÂÂÂ /* fall through */
> > ÂÂÂÂÂÂÂÂÂ case 0x70:
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂ s->fixed_format = 1;
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂ s->flags = sense[2] & 0xe0;
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂ break;
> > ÂÂÂÂÂÂÂÂÂ case 0x73:
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂ s->deferred = 1;
> > +ÂÂÂÂÂÂÂÂÂÂÂ /* fall through */
> > ÂÂÂÂÂÂÂÂÂ case 0x72:
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂ s->fixed_format = 0;
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂ ucp = scsi_sense_desc_find(sense, SCSI_SENSE_BUFFERSIZE, 4);
> > @@ -591,6 +593,7 @@ static void osst_init_aux(struct osst_tape * STp, int frame_type, int frame_seq_
> > ÂÂÂÂÂÂÂÂÂ dat->dat_list[0].flagsÂÂÂ = frame_type==OS_FRAME_TYPE_MARKER?
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ OS_DAT_FLAGS_MARK:OS_DAT_FLAGS_DATA;
> > ÂÂÂÂÂÂÂÂÂ dat->dat_list[0].reserved = 0;
> > +ÂÂÂÂÂÂÂ /* fall through */
> > ÂÂÂÂÂÂÂ caseÂÂÂ OS_FRAME_TYPE_EOD:
> > ÂÂÂÂÂÂÂÂÂ aux->update_frame_cntrÂÂÂ = htonl(0);
> > ÂÂÂÂÂÂÂÂÂ par->partition_numÂÂÂÂÂÂÂ = OS_DATA_PARTITION;
> > @@ -4086,6 +4089,7 @@ static int osst_int_ioctl(struct osst_tape * STp, struct osst_request ** aSRpnt,
> > ÂÂÂÂÂ switch (cmd_in) {
> > ÂÂÂÂÂÂ case MTFSFM:
> > ÂÂÂÂÂÂÂÂÂ chg_eof = 0; /* Changed from the FSF after this */
> > +ÂÂÂÂÂÂÂ /* fall through */
> > ÂÂÂÂÂÂ case MTFSF:
> > ÂÂÂÂÂÂÂÂÂ if (STp->raw)
> > ÂÂÂÂÂÂÂÂÂÂÂÂ return (-EIO);
> > @@ -4101,6 +4105,7 @@ static int osst_int_ioctl(struct osst_tape * STp, struct osst_request ** aSRpnt,
> > ÂÂÂÂÂÂ case MTBSF:
> > ÂÂÂÂÂÂÂÂÂ chg_eof = 0; /* Changed from the FSF after this */
> > +ÂÂÂÂÂÂÂ /* fall through */
> > ÂÂÂÂÂÂ case MTBSFM:
> > ÂÂÂÂÂÂÂÂÂ if (STp->raw)
> > ÂÂÂÂÂÂÂÂÂÂÂÂ return (-EIO);
> > @@ -4312,6 +4317,7 @@ static int osst_int_ioctl(struct osst_tape * STp, struct osst_request ** aSRpnt,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ name, STp->block_size);
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂ return 0;
> > ÂÂÂÂÂÂÂÂÂÂ }
> > +ÂÂÂÂÂÂÂ /* fall through */
> > ÂÂÂÂÂÂ case MTSETDENSITY:ÂÂÂÂÂÂ /* Set tape density */
> > ÂÂÂÂÂÂ case MTSETDRVBUFFER:ÂÂÂÂ /* Set drive buffering */
> > ÂÂÂÂÂÂ case SET_DENS_AND_BLK:ÂÂ /* Set density and block size */