Re: [PATCH 13/41] scsi: csiostor: csio_wr: mark expected switch fall-through

[Gustavo A. R. Silva]

Hi,

Friendly ping (second one):

Who can ack/review/take this patch, please?

Martin: apparently, the only maintainers for
this driver are you and James.

Thanks
--
Gustavo

On 12/19/18 9:39 AM, Gustavo A. R. Silva wrote:
> Hi,
>
> Friendly ping:
>
> Who can ack or review this patch, please?
>
> Thanks
> --
> Gustavo
>
> On 11/27/18 10:28 PM, Gustavo A. R. Silva wrote:
> > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > where we are expecting to fall through.
> >
> > Addresses-Coverity-ID: 1056538 ("Missing break in switch")
> > Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> > ---
> > Â drivers/scsi/csiostor/csio_wr.c | 1 +
> > Â 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/scsi/csiostor/csio_wr.c b/drivers/scsi/csiostor/csio_wr.c
> > index dc12933533d5..b6861ea66c9f 100644
> > --- a/drivers/scsi/csiostor/csio_wr.c
> > +++ b/drivers/scsi/csiostor/csio_wr.c
> > @@ -808,6 +808,7 @@ csio_wr_destroy_queues(struct csio_hw *hw, bool cmd)
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ csio_q_eqid(hw, i) = CSIO_MAX_QID;
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂ }
> > +ÂÂÂÂÂÂÂÂÂÂÂ /* fall through */
> > ÂÂÂÂÂÂÂÂÂ case CSIO_INGRESS:
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂ if (csio_q_iqid(hw, i) != CSIO_MAX_QID) {
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ csio_wr_cleanup_iq_ftr(hw, i);