Re: [PATCH 08/41] scsi: be2iscsi: be_main: Mark expected switch fall-through

From: Gustavo A. R. Silva
Date: Thu Jan 10 2019 - 15:13:07 EST


Hi,

Friendly ping (second one):

Who can ack/review/take this patch, please?

Thanks
--
Gustavo

On 12/19/18 9:38 AM, Gustavo A. R. Silva wrote:
Hi,

Friendly ping:

Who can ack or review this patch, please?

Thanks
--
Gustavo

On 11/27/18 10:27 PM, Gustavo A. R. Silva wrote:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 1357387 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
---
 drivers/scsi/be2iscsi/be_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index effb6fc95af4..b6449da1320c 100644
--- a/drivers/scsi/be2iscsi/be_main.c
+++ b/drivers/scsi/be2iscsi/be_main.c
@@ -1539,6 +1539,7 @@ beiscsi_hdl_get_handle(struct beiscsi_conn *beiscsi_conn,
ÂÂÂÂÂÂÂÂÂ break;
ÂÂÂÂÂ case UNSOL_DATA_DIGEST_ERROR_NOTIFY:
ÂÂÂÂÂÂÂÂÂ error = 1;
+ÂÂÂÂÂÂÂ /* fall through */
ÂÂÂÂÂ case UNSOL_DATA_NOTIFY:
ÂÂÂÂÂÂÂÂÂ pasync_handle = pasync_ctx->async_entry[ci].data;
ÂÂÂÂÂÂÂÂÂ break;