Re: [PATCH 12/41] scsi: bfa: bfa_ioc: Mark expected switch fall-throughs

[Gustavo A. R. Silva]

Hi,

Friendly ping (second one):

Who can ack/review/take this patch, please?

Thanks
--
Gustavo

On 12/19/18 9:39 AM, Gustavo A. R. Silva wrote:
> Hi,
>
> Friendly ping:
>
> Who can ack or review this patch, please?
>
> Thanks
> --
> Gustavo
>
> On 11/27/18 10:27 PM, Gustavo A. R. Silva wrote:
> > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > where we are expecting to fall through.
> >
> > Notice that, in this particular case, I replaced "!!! fall through !!!"
> > comment with "fall through" annotations, which is what GCC is expecting
> > to find.
> >
> > Addresses-Coverity-ID: 146155 ("Missing break in switch")
> > Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> > ---
> > Â drivers/scsi/bfa/bfa_ioc.c | 9 +++------
> > Â 1 file changed, 3 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/scsi/bfa/bfa_ioc.c b/drivers/scsi/bfa/bfa_ioc.c
> > index 16d3aeb0e572..32b24e51cce6 100644
> > --- a/drivers/scsi/bfa/bfa_ioc.c
> > +++ b/drivers/scsi/bfa/bfa_ioc.c
> > @@ -978,9 +978,7 @@ bfa_iocpf_sm_enabling(struct bfa_iocpf_s *iocpf, enum iocpf_event event)
> > ÂÂÂÂÂ case IOCPF_E_INITFAIL:
> > ÂÂÂÂÂÂÂÂÂ bfa_iocpf_timer_stop(ioc);
> > -ÂÂÂÂÂÂÂ /*
> > -ÂÂÂÂÂÂÂÂ * !!! fall through !!!
> > -ÂÂÂÂÂÂÂÂ */
> > +ÂÂÂÂÂÂÂ /* fall through */
> > ÂÂÂÂÂ case IOCPF_E_TIMEOUT:
> > ÂÂÂÂÂÂÂÂÂ writel(1, ioc->ioc_regs.ioc_sem_reg);
> > @@ -1056,9 +1054,7 @@ bfa_iocpf_sm_disabling(struct bfa_iocpf_s *iocpf, enum iocpf_event event)
> > ÂÂÂÂÂ case IOCPF_E_FAIL:
> > ÂÂÂÂÂÂÂÂÂ bfa_iocpf_timer_stop(ioc);
> > -ÂÂÂÂÂÂÂ /*
> > -ÂÂÂÂÂÂÂÂ * !!! fall through !!!
> > -ÂÂÂÂÂÂÂÂ */
> > +ÂÂÂÂÂÂÂ /* fall through */
> > ÂÂÂÂÂ case IOCPF_E_TIMEOUT:
> > ÂÂÂÂÂÂÂÂÂ bfa_ioc_set_cur_ioc_fwstate(ioc, BFI_IOC_FAIL);
> > @@ -6007,6 +6003,7 @@ bfa_dconf_sm_final_sync(struct bfa_dconf_mod_s *dconf,
> > ÂÂÂÂÂ case BFA_DCONF_SM_IOCDISABLE:
> > ÂÂÂÂÂ case BFA_DCONF_SM_FLASH_COMP:
> > ÂÂÂÂÂÂÂÂÂ bfa_timer_stop(&dconf->timer);
> > +ÂÂÂÂÂÂÂ /* fall through */
> > ÂÂÂÂÂ case BFA_DCONF_SM_TIMEOUT:
> > ÂÂÂÂÂÂÂÂÂ bfa_sm_set_state(dconf, bfa_dconf_sm_uninit);
> > ÂÂÂÂÂÂÂÂÂ bfa_fsm_send_event(&dconf->bfa->iocfc, IOCFC_E_DCONF_DONE);