Re: [PATCH 3/4] crypto: hisilicon: Add HiSilicon ZIP accelerator support

[Zhou Wang]

On 2019/1/11 14:08, Herbert Xu wrote:
> On Sat, Dec 22, 2018 at 03:51:44PM +0800, Zhou Wang wrote:
>>
>> +static struct crypto_alg hisi_zip_zlib = {
>> +	.cra_name		= "zlib-deflate",
>> +	.cra_flags		= CRYPTO_ALG_TYPE_COMPRESS,
>> +	.cra_ctxsize		= sizeof(struct hisi_zip_ctx),
>> +	.cra_priority           = 300,
>> +	.cra_module		= THIS_MODULE,
>> +	.cra_init		= hisi_zip_alloc_comp_ctx,
>> +	.cra_exit		= hisi_zip_free_comp_ctx,
>> +	.cra_u			= {
>> +		.compress = {
>> +			.coa_compress	= hisi_zip_compress,
>> +			.coa_decompress	= hisi_zip_decompress
>> +		}
>> +	}
>> +};
> 
> Please do not add any new implementations using the compress
> interface.  You should either use scomp or acomp depending on
> whether your driver is synchronous or async.

OK, current this driver only supports synchronous interface.
Will fix it in v2.

Thanks,
Zhou

> 
> Thanks,
>