Re: [PATCH] drivers/usb/storage/sddr55.c: Remove duplicate header

[Greg KH]

On Thu, Jan 10, 2019 at 01:10:25PM +0530, Sabyasachi Gupta wrote:
> Remove unusual_sddr55.h which is included more than once
> 
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@xxxxxxxxx>
> ---
>  drivers/usb/storage/sddr55.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/storage/sddr55.c b/drivers/usb/storage/sddr55.c
> index b8527c5..96bf7ee 100644
> --- a/drivers/usb/storage/sddr55.c
> +++ b/drivers/usb/storage/sddr55.c
> @@ -62,7 +62,6 @@ MODULE_DEVICE_TABLE(usb, sddr55_usb_ids);
>  }
>  
>  static struct us_unusual_dev sddr55_unusual_dev_list[] = {
> -#	include "unusual_sddr55.h"
>  	{ }		/* Terminating entry */
>  };

As Oliver said on the other patch, this breaks the code.  Please do not
blindly make changes without understanding what the code does.

thanks,

greg k-h