Re: [PATCH v3 1/3] iio: ti-ads124s08: Add DT binding documentation

From: Jonathan Cameron
Date: Sat Jan 12 2019 - 13:41:01 EST


On Fri, 11 Jan 2019 13:57:05 -0600
Dan Murphy <dmurphy@xxxxxx> wrote:

> Adding binding documentation for Texas Instruments ADS124S08
> and ADS124S06 ADC.
>
> S08 is a 12 channel ADC
> S06 is a 6 channel ADC
>
> Datesheet can be found here:
> http://www.ti.com/lit/gpn/ads124s08
>
> Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
Hopefully I haven't missed anything and this one is as trivial as I think.
Applied to the togreg branch of iio.git and pushed out as testing.

Comments still welcome. I'll push this out as a non rebasing tree
later in the week.

Thanks,

Jonathan

> ---
>
> v3 - Fixed the compatible made the colon spacing consistent - https://lore.kernel.org/patchwork/patch/1023969/
> v2 - Fixed incorrect compatible example and removed vref-supply - https://lore.kernel.org/patchwork/patch/1021047/
>
> .../bindings/iio/adc/ti-ads124s08.txt | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads124s08.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti-ads124s08.txt b/Documentation/devicetree/bindings/iio/adc/ti-ads124s08.txt
> new file mode 100644
> index 000000000000..ecf807bb32f7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti-ads124s08.txt
> @@ -0,0 +1,25 @@
> +* Texas Instruments' ads124s08 and ads124s06 ADC chip
> +
> +Required properties:
> + - compatible :
> + "ti,ads124s08"
> + "ti,ads124s06"
> + - reg : spi chip select number for the device
> +
> +Recommended properties:
> + - spi-max-frequency : Definition as per
> + Documentation/devicetree/bindings/spi/spi-bus.txt
> + - spi-cpha : Definition as per
> + Documentation/devicetree/bindings/spi/spi-bus.txt
> +
> +Optional properties:
> + - reset-gpios : GPIO pin used to reset the device.
> +
> +Example:
> +adc@0 {
> + compatible = "ti,ads124s08";
> + reg = <0>;
> + spi-max-frequency = <1000000>;
> + spi-cpha;
> + reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
> +};