Re: [PATCH v2] drm/drm_vblank: Change EINVAL by the correct errno

[Maarten Lankhorst]

Op 13-01-2019 om 21:23 schreef Rodrigo Siqueira:
> Hi,
>
> I resend this patch for CI via âintel-gfx@xxxxxxxxxxxxxxxxxxxxxâ as
> Daniel suggested, and I got a feedback that reported an issue as can be
> seen here:
>
>    https://patchwork.freedesktop.org/series/51147/
>
> After a careful analysis of what happened, I concluded that the problem
> is related to the function âigt_wait_for_vblank_count()â in âigt_kms.câ.
> This function has the following assert:
>
>    igt_assert(drmWaitVBlank(drm_fd, &wait_vbl) == 0)
>
> This function only checks if everything went well with the
> drmWaitVBlank() operation and does not make any other validation. IMHO
> the patch is correct, and the problem pointed out by CI is not related
> to this change.

Hey,

Thanks for finding the root cause. Before upstreaming can you send a fix for i-g-t so we don't lose CI coverage after changing the behavior?

~Maarten