Re: [PATCH] scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom

From: Doug Anderson
Date: Mon Jan 14 2019 - 12:08:16 EST


Hi,

On Fri, Jan 11, 2019 at 7:37 PM Martin K. Petersen
<martin.petersen@xxxxxxxxxx> wrote:
>
>
> Evan,
>
> > CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that
> > this was the only possible PHY driver Qualcomm's UFS controller
> > would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp,
> > and phy-qcom-ufs is unused.
> >
> > Remove the select, since for SDM845 it adds useless drivers to the
> > build.
>
> Applied to 5.1/scsi-queue.

Should this be accompanied by a change to arch/arm64/configs/defconfig
that sets 'CONFIG_PHY_QCOM_UFS=m'? I don't personally have any
non-SDM845 devices to test on, but I'm sorta assuming they will all
break without the defconfig update?

Added a few more people (and linux-arm-msm list) to this thread in
case this matters to anyone.

-Doug