Re: [PATCH v10 05/12] ARM: dts: aspeed: peci: Add PECI node

[Jae Hyun Yoo]

Hi Joel,

On 1/13/2019 9:45 PM, Joel Stanley wrote:
> Hi Jae,
>
> On Tue, 8 Jan 2019 at 08:11, Jae Hyun Yoo <jae.hyun.yoo@xxxxxxxxxxxxxxx> wrote:
> > This commit adds PECI bus/adapter node of AST24xx/AST25xx into
> > aspeed-g4 and aspeed-g5.
>
> This looks good, aside from the alias.
>
> It will go via my aspeed tree once the bindings are merged. Send them
> to linux-aspeed@xxxxxxxxxxxxxxxx at that time.
>
> In the future I suggest leaving the changes to arch/arm/boot/dts until
> after the bindings and driver patches have landed. They will rarely go
> in before hand as the bindings need to be agreed on.

I thought that it would be helpful if it shows an actual example in this
series because it is trying to add a new subsystem. In the future, I'll
submit a dts patch separately from bindings and drivers, but I'd like
to keep this dts changes in this series because it has been already
submitted. I'll CC linux-aspeed list from the next version. Thanks!

> >                  serial3 = &uart4;
> >                  serial4 = &uart5;
> >                  serial5 = &vuart;
> > +               peci0 = &peci0;
>
> I don't think this is necessary. Can you explain why you think you need it?

You are right. This alias is not necessary at all. Will drop it.

Thanks,
Jae

> Cheers,
>
> Joel