Re: [PATCH v4 02/14] pinctrl: qcom: spmi-gpio: add support for three new variants

[Bjorn Andersson]

On Sun 13 Jan 07:47 PST 2019, Brian Masney wrote:

> Add support for qcom,pm8005-gpio, qcom,pm8998-gpio, and
> qcom,pmi8998-gpio. These three variants are already in use in some
> arm64 dtsi files. Those boards work since the generic binding
> qcom,spmi-gpio is also specified.
> 

Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

> Signed-off-by: Brian Masney <masneyb@xxxxxxxxxxxxx>
> ---
> This is a new patch introduced in V4.
> 
>  drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index 4458d44dfcf6..5f2977982ef1 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -1063,10 +1063,13 @@ static int pmic_gpio_remove(struct platform_device *pdev)
>  }
>  
>  static const struct of_device_id pmic_gpio_of_match[] = {
> +	{ .compatible = "qcom,pm8005-gpio" },	/* 4 GPIO's */
>  	{ .compatible = "qcom,pm8916-gpio" },	/* 4 GPIO's */
>  	{ .compatible = "qcom,pm8941-gpio" },	/* 36 GPIO's */
>  	{ .compatible = "qcom,pm8994-gpio" },	/* 22 GPIO's */
>  	{ .compatible = "qcom,pmi8994-gpio" },  /* 10 GPIO's */
> +	{ .compatible = "qcom,pm8998-gpio" },	/* 26 GPIO's */
> +	{ .compatible = "qcom,pmi8998-gpio" },	/* 14 GPIO's */
>  	{ .compatible = "qcom,pma8084-gpio" },	/* 22 GPIO's */
>  	{ .compatible = "qcom,pms405-gpio" },	/* 12 GPIO's, holes on 1 9 10 */
>  	{ .compatible = "qcom,spmi-gpio" }, /* Generic */
> -- 
> 2.17.2
>