Re: [PATCH v4 09/14] ARM: dts: qcom: pma8084: add interrupt controller properties
From: Bjorn Andersson
Date: Mon Jan 14 2019 - 19:43:01 EST
On Sun 13 Jan 07:47 PST 2019, Brian Masney wrote:
> Add interrupt controller properties now that spmi-gpio is a proper
> hierarchical IRQ chip. The interrupts property is no longer needed so
> remove it.
>
> This change was not tested on any hardware but the same change was
> tested on qcom-pm8941.dtsi using a LG Nexus 5 (hammerhead) phone with
> no issues.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> Signed-off-by: Brian Masney <masneyb@xxxxxxxxxxxxx>
> Reviewed-by: Stephen Boyd <sboyd@xxxxxxxxxx>
> ---
> Chances since v3:
> - None
>
> arch/arm/boot/dts/qcom-pma8084.dtsi | 24 ++----------------------
> 1 file changed, 2 insertions(+), 22 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-pma8084.dtsi b/arch/arm/boot/dts/qcom-pma8084.dtsi
> index aac7e73b6872..8f5ea7add20f 100644
> --- a/arch/arm/boot/dts/qcom-pma8084.dtsi
> +++ b/arch/arm/boot/dts/qcom-pma8084.dtsi
> @@ -32,28 +32,8 @@
> reg = <0xc000>;
> gpio-controller;
> #gpio-cells = <2>;
> - interrupts = <0 0xc0 0 IRQ_TYPE_NONE>,
> - <0 0xc1 0 IRQ_TYPE_NONE>,
> - <0 0xc2 0 IRQ_TYPE_NONE>,
> - <0 0xc3 0 IRQ_TYPE_NONE>,
> - <0 0xc4 0 IRQ_TYPE_NONE>,
> - <0 0xc5 0 IRQ_TYPE_NONE>,
> - <0 0xc6 0 IRQ_TYPE_NONE>,
> - <0 0xc7 0 IRQ_TYPE_NONE>,
> - <0 0xc8 0 IRQ_TYPE_NONE>,
> - <0 0xc9 0 IRQ_TYPE_NONE>,
> - <0 0xca 0 IRQ_TYPE_NONE>,
> - <0 0xcb 0 IRQ_TYPE_NONE>,
> - <0 0xcc 0 IRQ_TYPE_NONE>,
> - <0 0xcd 0 IRQ_TYPE_NONE>,
> - <0 0xce 0 IRQ_TYPE_NONE>,
> - <0 0xcf 0 IRQ_TYPE_NONE>,
> - <0 0xd0 0 IRQ_TYPE_NONE>,
> - <0 0xd1 0 IRQ_TYPE_NONE>,
> - <0 0xd2 0 IRQ_TYPE_NONE>,
> - <0 0xd3 0 IRQ_TYPE_NONE>,
> - <0 0xd4 0 IRQ_TYPE_NONE>,
> - <0 0xd5 0 IRQ_TYPE_NONE>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> };
>
> pma8084_mpps: mpps@a000 {
> --
> 2.17.2
>