Re: [PATCH 1/2] staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS_SETPAR

From: Greg Kroah-Hartman
Date: Tue Jan 15 2019 - 08:45:59 EST


On Tue, Jan 15, 2019 at 01:12:28PM +0100, Daniel Vetter wrote:
> On Tue, Jan 15, 2019 at 11:38:29AM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Jan 15, 2019 at 11:27:54AM +0100, Daniel Vetter wrote:
> > > It's a debug hack flag useful to work around driver bugs. That's not a
> > > good idea for a new driver. Especially for a new drm driver.
> > >
> > > Aside: the fbdev support should probably be converted over to the new
> > > generic fbdev support.
> > >
> > > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
> > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > Cc: Hans de Goede <hdegoede@xxxxxxxxxx>
> > > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> > > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> > > Cc: Alexander Kapshuk <alexander.kapshuk@xxxxxxxxx>
> > > ---
> > > drivers/staging/vboxvideo/vbox_fb.c | 5 -----
> > > 1 file changed, 5 deletions(-)
> > >
> >
> > Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> Since Hans wants to destage vboxvideo this cycle probably best I merge
> this through drm-misc? Just to make sure it's not lost.

Feel free to do so!

thanks,

greg k-h