Re: [PATCH] mm, memory_hotplug: __offline_pages fix wrong locking

[Oscar Salvador]

On Tue, Jan 15, 2019 at 01:03:07PM +0100, Michal Hocko wrote:
> From: Michal Hocko <mhocko@xxxxxxxx>
> 
> Jan has noticed that we do double unlock on some failure paths when
> offlining a page range. This is indeed the case when test_pages_in_a_zone
> respp. start_isolate_page_range fail. This was an omission when forward
> porting the debugging patch from an older kernel.
> 
> Fix the issue by dropping mem_hotplug_done from the failure condition
> and keeping the single unlock in the catch all failure path.
> 
> Reported-by: Jan Kara <jack@xxxxxxx>
> Fixes: 7960509329c2 ("mm, memory_hotplug: print reason for the offlining failure")
> Signed-off-by: Michal Hocko <mhocko@xxxxxxxx>

Uhmf, I overlooked that while reviewing the patch.

Reviewed-by: Oscar Salvador <osalvador@xxxxxxx>

Thanks
-- 
Oscar Salvador
SUSE L3