Re: [PATCH] arch: riscv: support kernel command line forcing when no DTB passed

From: Christoph Hellwig
Date: Tue Jan 15 2019 - 10:44:58 EST


On Mon, Dec 17, 2018 at 07:15:12PM -0800, Paul Walmsley wrote:
>
> CONFIG_CMDLINE_FORCE doesn't work on RISC-V when no DTB is passed into
> the kernel. This is because the code that forces the kernel command
> line only runs if a valid DTB is present at boot. During debugging,
> it's useful to have the ability to force kernel command lines even
> when no DTB is present. This patch adds support for doing so.

This looks fine to me:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

I just wish all this command line magic could be moved to common
code somewhere instead of being reinvented badly in every port..