Re: [PATCH v3 1/5] misc: dt-bindings: Add Qualcomm Fastrpc bindings

[Rob Herring]

On Mon, Jan 14, 2019 at 07:41:08PM +0000, Srinivas Kandagatla wrote:
> The FastRPC driver implements an IPC (Inter-Processor Communication)
> mechanism that allows for clients to transparently make remote method
> invocations across DSP and APPS boundaries. This enables developers
> to offload tasks to the DSP and free up the application processor for
> other tasks.
> 
> Co-developed-by: Thierry Escande <thierry.escande@xxxxxxxxxx>
> Signed-off-by: Thierry Escande <thierry.escande@xxxxxxxxxx>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> ---
>  .../devicetree/bindings/misc/qcom,fastrpc.txt | 84 +++++++++++++++++++
>  1 file changed, 84 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/misc/qcom,fastrpc.txt
> 
> diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt b/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt
> new file mode 100644
> index 000000000000..004e636b4133
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt
> @@ -0,0 +1,84 @@
> +Qualcomm Technologies, Inc. FastRPC Driver
> +
> +The FastRPC driver implements an IPC (Inter-Processor Communication)

driver or this is a h/w block?

> +mechanism that allows for clients to transparently make remote method
> +invocations across DSP and APPS boundaries. This enables developers
> +to offload tasks to the DSP and free up the application processor for
> +other tasks.
> +
> +- compatible:
> +	Usage: required
> +	Value type: <stringlist>
> +	Definition: must be "qcom,fastrpc"
> +
> +- label
> +	Usage: required
> +	Value type: <string>
> +	Definition: should specify the dsp domain name this fastrpc
> +	corresponds to. must be one of this: "adsp", "mdsp", "sdsp", "cdsp"
> +
> +- #address-cells
> +	Usage: required
> +	Value type: <u32>
> +	Definition: Must be 1
> +
> +- #size-cells
> +	Usage: required
> +	Value type: <u32>
> +	Definition: Must be 0
> +
> += COMPUTE BANKS
> +Each subnode of the Fastrpc node represents compute context banks available
> +on the dsp. The name of the nodes are not important. The properties of these

Please specify what the node names are.

> +nodes are defined by the individual bindings for the specific service
> +- All Compute context banks MUST contain the following property:
> +
> +- compatible:
> +	Usage: required
> +	Value type: <stringlist>
> +	Definition: must be "qcom,fastrpc-compute-cb"
> +
> +- reg
> +	Usage: required
> +	Value type: <u32>
> +	Definition: Context Bank ID.
> +
> +- secured:
> +	Usage: Optional
> +	Value type: <boolean>
> +	Defination: Indicating context bank is secured

What does 'secured' mean here?

> +
> +- nsessions:
> +	Usage: Optional
> +	Value type: <u32>
> +	Defination: A value indicating how many sessions can share this
> +		    context bank. Defaults to 1 when this property
> +		    is not specified.

Needs a vendor prefix.

> +
> +Example:
> +
> +adsp-pil {
> +	compatible = "qcom,msm8996-adsp-pil";
> +	...
> +	smd-edge {
> +		label = "lpass";
> +		fastrpc {
> +			compatible = "qcom,fastrpc";
> +			qcom,smd-channels = "fastrpcsmd-apps-dsp";
> +			lable = "adsp";

typo.

> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			cb@1 {
> +				compatible = "qcom,fastrpc-compute-cb";
> +				reg = <1>;
> +			};
> +
> +			cb@2 {
> +				compatible = "qcom,fastrpc-compute-cb";
> +				reg = <2>;
> +			};
> +			...
> +		};
> +	};
> +};
> -- 
> 2.20.1
>