Re: [PATCH 1/2] staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS_SETPAR

From: Daniel Vetter
Date: Wed Jan 16 2019 - 05:05:39 EST


On Tue, Jan 15, 2019 at 4:32 PM Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Tue, Jan 15, 2019 at 04:15:49PM +0100, Daniel Vetter wrote:
> > On Tue, Jan 15, 2019 at 02:45:53PM +0100, Greg Kroah-Hartman wrote:
> > > On Tue, Jan 15, 2019 at 01:12:28PM +0100, Daniel Vetter wrote:
> > > > On Tue, Jan 15, 2019 at 11:38:29AM +0100, Greg Kroah-Hartman wrote:
> > > > > On Tue, Jan 15, 2019 at 11:27:54AM +0100, Daniel Vetter wrote:
> > > > > > It's a debug hack flag useful to work around driver bugs. That's not a
> > > > > > good idea for a new driver. Especially for a new drm driver.
> > > > > >
> > > > > > Aside: the fbdev support should probably be converted over to the new
> > > > > > generic fbdev support.
> > > > > >
> > > > > > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
> > > > > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > > > > Cc: Hans de Goede <hdegoede@xxxxxxxxxx>
> > > > > > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> > > > > > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> > > > > > Cc: Alexander Kapshuk <alexander.kapshuk@xxxxxxxxx>
> > > > > > ---
> > > > > > drivers/staging/vboxvideo/vbox_fb.c | 5 -----
> > > > > > 1 file changed, 5 deletions(-)
> > > > > >
> > > > >
> > > > > Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > >
> > > > Since Hans wants to destage vboxvideo this cycle probably best I merge
> > > > this through drm-misc? Just to make sure it's not lost.
> > >
> > > Feel free to do so!
> >
> > Applied, thanks for your review.
> >
> > I think 2/2 is directly staging material for you (somehow
> > get_maintainers.pl didn't add you to the cc: list, not sure why ...).
>
> Can you resend it, I don't see it anywhere...

resent with you added explicitly to the Cc: list, it's

Subject: [PATCH] staging/xgifb: Needs to be converted to a drm driver
Date: Wed, 16 Jan 2019 11:04:40 +0100
Message-Id: <20190116100440.10071-1-daniel.vetter@xxxxxxxx>

Cheers, Daniel

> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel



--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch