Re: [PATCH 3/3] virtio-blk: Consider dma_max_mapping_size() for maximum segment size
From: Joerg Roedel
Date: Wed Jan 16 2019 - 09:10:50 EST
On Wed, Jan 16, 2019 at 09:05:40AM -0500, Michael S. Tsirkin wrote:
> On Tue, Jan 15, 2019 at 02:22:57PM +0100, Joerg Roedel wrote:
> > + max_size = dma_max_mapping_size(&vdev->dev);
> > +
> Should this be limited to ACCESS_PLATFORM?
> I see no reason to limit this without as guest can
> access any memory.
Actually, yes. This should be inside a use_dma_api check. I had it in
v1, but it went away without the vring layer for propagating the limit.
I'll add that again.