Re: [PATCH 1/3] net: dsa: lantiq_gswip: fix use-after-free on failed probe

From: Andrew Lunn
Date: Wed Jan 16 2019 - 17:15:10 EST


> > This is correct. But it would be nice if somebody in the future could
> > move the disabling of the switch to the inverse of the gswip_setup()
> > function to make the code symmetrical.
>
> Should we add an uninit callback?

Yes, that would be good.

It looks like lan9303-core.c could use it as well for
lan9303_disable_processing(chip);

Thanks
Andrew