Re: [PATCH 2/5] ipc: introduce ksys_ipc()/compat_ksys_ipc() for s390

From: Heiko Carstens
Date: Thu Jan 17 2019 - 15:13:55 EST


On Thu, Jan 17, 2019 at 05:29:55PM +0100, Arnd Bergmann wrote:
> On Thu, Jan 17, 2019 at 2:29 PM Heiko Carstens
> > SYSCALL_DEFINE1(s390_personality, unsigned int, personality)
> > {
> > diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c
> > index ab9d0e3c6d50..ad016a7db0ea 100644
> > --- a/kernel/sys_ni.c
> > +++ b/kernel/sys_ni.c
> > @@ -366,7 +366,7 @@ COND_SYSCALL(kexec_file_load);
> > /* s390 */
> > COND_SYSCALL(s390_pci_mmio_read);
> > COND_SYSCALL(s390_pci_mmio_write);
> > -COND_SYSCALL_COMPAT(s390_ipc);
> > +COND_SYSCALL(s390_ipc);
> >
> > /* powerpc */
> > COND_SYSCALL(rtas);
>
> I think you need to keep the
>
> COND_SYSCALL_COMPAT(s390_ipc);
>
> here, otherwise it still fails with CONFIG_SYSV_IPC=n, CONFIG_COMPAT=y, right?

Yes, you're right.