Re: [for-next][PATCH] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled

[Rafael J. Wysocki]

On Thu, Jan 17, 2019 at 10:56 PM Borislav Petkov <bp@xxxxxxxxx> wrote:
>
> On Thu, Jan 17, 2019 at 11:42:39AM -0500, Sinan Kaya wrote:
> > On 1/17/2019 11:37 AM, Borislav Petkov wrote:
> > > Also, I see a lot of build failures when doing randconfig builds for the
> > > stuff in drivers/platform/x86/Kconfig. Is someone picking those up too?
> >
> > Can you share the build failures you are seeing?
>
> Here are three configs which fail.
>
> They have in common:
>
> # CONFIG_PCI is not set
>
> As a tip for the future - always build the default
> def/allno/yes/modconfig targets and as many randconfigs as possible when
> changing Kconfig dependencies. I've learned that the hard way.
>
> Here are the build failures:
>
> arch/x86/kernel/ftrace.c:668:23: warning: âftrace_jmp_replaceâ defined but not used [-Wunused-function]
> drivers/platform/x86/intel_ips.c: In function âips_probeâ:
> drivers/platform/x86/intel_ips.c:1463:2: error: implicit declaration of function âpcim_enable_deviceâ [-Werror=implicit-function-declaration]
> drivers/platform/x86/intel_ips.c:1525:2: error: implicit declaration of function âpci_alloc_irq_vectorsâ [-Werror=implicit-function-declaration]
> drivers/platform/x86/intel_ips.c:1525:41: error: âPCI_IRQ_LEGACYâ undeclared (first use in this function)
> drivers/platform/x86/intel_ips.c:1525:41: note: each undeclared identifier is reported only once for each function it appears in
> drivers/platform/x86/intel_ips.c:1529:2: error: implicit declaration of function âpci_irq_vectorâ [-Werror=implicit-function-declaration]
> drivers/platform/x86/intel_ips.c:1592:2: error: implicit declaration of function âpci_free_irq_vectorsâ [-Werror=implicit-function-declaration]
> drivers/platform/x86/intel_ips.c: At top level:
> drivers/platform/x86/intel_ips.c:1636:1: warning: data definition has no type or storage class [enabled by default]
> drivers/platform/x86/intel_ips.c:1636:1: error: type defaults to âintâ in declaration of âmodule_pci_driverâ [-Werror=implicit-int]
> drivers/platform/x86/intel_ips.c:1636:1: warning: parameter names (without types) in function declaration [enabled by default]
> drivers/platform/x86/intel_ips.c:1629:26: warning: âips_pci_driverâ defined but not used [-Wunused-variable]
> make[3]: *** [drivers/platform/x86/intel_ips.o] Error 1
> make[2]: *** [drivers/platform/x86] Error 2
>
> drivers/platform/x86/apple-gmux.c: In function âgmux_probeâ:
> drivers/platform/x86/apple-gmux.c:746:22: error: âpci_bus_typeâ undeclared (first use in this function)
> drivers/platform/x86/apple-gmux.c:746:22: note: each undeclared identifier is reported only once for each function it appears in
> make[3]: *** [drivers/platform/x86/apple-gmux.o] Error 1
>
> drivers/platform/x86/intel_pmc_ipc.c: In function âipc_pci_probeâ:
> drivers/platform/x86/intel_pmc_ipc.c:520:2: error: implicit declaration of function âpcim_enable_deviceâ [-Werror=implicit-function-declaration]
> make[3]: *** [drivers/platform/x86/intel_pmc_ipc.o] Error 1
>
> You get the idea...

I have patches for intel_ips and intel_pmc_ipc queued up (will be
pushed for -rc3), plus some others.  apple-gmux is a new one.