Re: [PATCH v11 0/9] Add power domain driver for corners on msm8996/sdm845

[Marc Gonzalez]

On 18/01/2019 04:54, Rajendra Nayak wrote:

> On 1/17/2019 8:33 PM, Marc Gonzalez wrote:
> 
>> On 10/01/2019 05:02, Rajendra Nayak wrote:
>>
>>> Rajendra Nayak (9):
>>>    dt-bindings: opp: Introduce opp-level bindings
>>>    OPP: Add support for parsing the 'opp-level' property
>>>    dt-bindings: power: Add qcom rpm power domain driver bindings
>>>    soc: qcom: rpmpd: Add a Power domain driver to model corners
>>>    soc: qcom: rpmpd: Add support for get/set performance state
>>>    arm64: dts: msm8996: Add rpmpd device node
>>>    soc: qcom: rpmhpd: Add RPMh power domain driver
>>>    arm64: dts: sdm845: Add rpmh powercontroller node
>>>    soc: qcom: rpmhpd: Mark mx as a parent for cx
>>>
>>>   Documentation/devicetree/bindings/opp/opp.txt |   3 +
>>>   .../devicetree/bindings/power/qcom,rpmpd.txt  | 145 +++++++
>>>   arch/arm64/boot/dts/qcom/msm8996.dtsi         |  34 ++
>>>   arch/arm64/boot/dts/qcom/sdm845.dtsi          |  51 +++
>>
>> Whenever I see these patches adding support for msm8996 (aka sdm820) and sdm845
>> simultaneously, I think to myself: "Why is sdm835 being left out? It was released
>> between sdm820 and sdm845, it cannot be /that/ different."
> 
> It isn't that different, and it should be quite straight forward to add support for it
> with the rpmpd driver (the rpmhpd is for platforms sdm845 and beyond which use rpmh)
> 
> When I started working on these patches, support for sdm835 upstream was non-existent
> so I started off with what was the better supported one which was the 820 (msm8996).

Once you land this patch series, could you take a quick look at how much work is needed
to add msm8998 support? I'm betting it would take you only a few hours.

Regards.