Re: [PATCH v2 1/2] gpio: hlwd: Add basic IRQ support

From: Linus Walleij
Date: Mon Jan 21 2019 - 08:34:34 EST


On Mon, Jan 14, 2019 at 8:15 PM Jonathan NeuschÃfer
<j.neuschaefer@xxxxxxx> wrote:

> This patch implements level-triggered IRQs in the Hollywood GPIO driver.
> Edge triggered interrupts are not supported in this GPIO controller, so
> I moved their emulation into a separate patch.
>
> Signed-off-by: Jonathan NeuschÃfer <j.neuschaefer@xxxxxxx>
> ---
>
> v2:
> - Changed register addresses to io{read,write}32be() instead of
> hlwd->gpioc.{read,write}_reg, as suggested by Linus Walleij.
> - Changed the IRQ chip's name from "GPIO" to dev_name(&pdev->dev), which
> is "d8000c0.gpio" for the one GPIO controller in the Wii, but might
> help tell the two GPIO controllers in the Wii U apart.
> (also suggested by Linus Walleij)

Excellent work, patch applied!

Yours,
Linus Walleij