Re: [PATCH] net/ipv6: lower the level of "link is not ready" messages

[Thomas Haller]

On Mon, 2019-01-21 at 14:54 +0100, Lubomir Rintel wrote:
> This message gets logged far too often for how interesting is it.
> 
> Most distributions nowadays configure NetworkManager to use randomly
> generated MAC addresses for Wi-Fi network scans. The interfaces end
> up
> being periodically brought down for the address change. When they're
> subsequently brought back up, the message is logged, eventually
> flooding
> the log.
> 
> Perhaps the message is not all that helpful: it seems to be more
> interesting to hear when the addrconf actually start, not when it
> does
> not. Let's lower its level.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@xxxxx>


Hi,

a NetworkManager maintainer here.

Acked-By: Thomas Haller <thaller@xxxxxxxxxx>


> ---
>  net/ipv6/addrconf.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index 93d5ad2b1a69..ba155841dc15 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -3495,8 +3495,8 @@ static int addrconf_notify(struct
> notifier_block *this, unsigned long event,
>  
>  			if (!addrconf_link_ready(dev)) {
>  				/* device is not ready yet. */
> -				pr_info("ADDRCONF(NETDEV_UP): %s: link
> is not ready\n",
> -					dev->name);
> +				pr_debug("ADDRCONF(NETDEV_UP): %s: link
> is not ready\n",
> +					 dev->name);
>  				break;
>  			}