Re: [PATCH] dma-debug: add dumping facility via debugfs
From: Joerg Roedel
Date: Tue Jan 22 2019 - 08:25:55 EST
On Fri, Jan 18, 2019 at 12:35:43PM +0100, Christoph Hellwig wrote:
> On Wed, Jan 16, 2019 at 06:10:13PM +0000, Robin Murphy wrote:
> > It's a shame that this is pretty much a duplication of
> > debug_dma_dump_mappings(), but there seems no straightforward way to define
> > one in terms of the other :/
> We could always play some macro magic, but I think that is worse than
> duplicating a little bit of functionality.
I havn't checked in detail, can seq_buf be used somehow to write a
function that fits both cases?
> Btw, the dev argument to debug_dma_dump_mappings is always NULL and
> could be removed..
This function was also written as a debug-helper for driver developers.
As such it might not make it into the final driver, but the developer
might want to use it to dump the mappings for her device only. So I'd
like to keep the parameter, even when it is always NULL for in-kernel
> > (although given that we'd rather not have that weird external interface
> > anyway, maybe "now you can use debugfs instead" might be justification
> > enough for cleaning it up...)
> One argument against that is the system might be in a shape where you
> can't easily read a file when it is in that shape. The argument for
> that is that in many systems the full list of mappings might overwhelm
> the kernel log.
For driver developers a file is easier to use, but in case of an
unusable system one can at least easily read out parts of the
dma-mappings from a crash-dump if it is in the kernel-log. So I think
it makes sense to have both.