Re: [PATCH] lib/test_kmod: Potential double free in error handling

From: Luis Chamberlain
Date: Tue Jan 22 2019 - 14:47:22 EST


On Mon, Jan 21, 2019 at 05:00:11PM +0300, Dan Carpenter wrote:
> There is a copy and paste bug so we set "config->test_driver" to NULL
> twice instead of setting "config->test_fs". Smatch complains that it
> leads to a double free:
>
> lib/test_kmod.c:840 __kmod_config_init() warn: 'config->test_fs' double freed
>
> Fixes: d9c6a72d6fa2 ("kmod: add test driver to stress test the module loader")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Thanks!

Acked-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>

Luis