Re: [PATCH v3] tty: moxa: Fix coding style issues

From: Greg KH
Date: Wed Jan 23 2019 - 02:06:32 EST


On Tue, Jan 22, 2019 at 05:30:55PM -0500, Antoine Robertson wrote:
> Fix coding style issues

That is really vague, you need to say exactly what type of coding style
fixes you made here.

And if you made more than one "type" of fix, then you need to break the
patch up into a series, only doing one "type" of fix per patch.

Yeah, that's a pain for when there are only tiny things that need to be
changed, but that way it makes it easier for reviewers, and for fixing
if it turns out any of your changes was not ok.

I recommend, if you want to do coding style fixes, to do so in the
drivers/staging/ part of the kernel. That area has a lot more work to
be done and you don't end up doing tiny things like this.

thanks,

greg k-h