Re: [PATCH V3] livepatch: non static warnings fix

From: Miroslav Benes
Date: Wed Jan 23 2019 - 09:31:01 EST


Hi,

On Wed, 23 Jan 2019, Nicholas Mc Guire wrote:

> Sparse reported warnings about non-static symbols. For the variables
> a simple static attribute is fine - for the functions referenced by
> livepatch via klp_func the symbol-names must be unmodified in the
> symbol table and the patchable code has to be emitted. The resolution
> is to attach __used attribute to the shared statically declared functions.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx>
> Suggested-by: Joe Lawrence <joe.lawrence@xxxxxxxxxx>
> Link: https://lkml.org/lkml/2018/12/13/827

could you reorder the tags and change Link: tag to
https://lkml.kernel.org/r/<message_id> as asked for when we reviewed v2?

With that

Acked-by: Miroslav Benes <mbenes@xxxxxxx>

M