Re: [PATCH v3 1/5] usb: fsl: Set USB_EN bit to select ULPI phy

[Alan Stern]

On Wed, 23 Jan 2019, Yinbo Zhu wrote:

> From: Nikhil Badola <nikhil.badola@xxxxxxxxxxxxx>
> 
> Set USB_EN bit to select ULPI phy for USB controller version 2.5
> 
> Signed-off-by: Nikhil Badola <nikhil.badola@xxxxxxxxxxxxx>
> Signed-off-by: Yinbo Zhu <yinbo.zhu@xxxxxxx>
> ---
> Change in v3:
> 		Code base already has patch[5/6], so remove it.  
> 
>  drivers/usb/host/ehci-fsl.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> index e3d0c1c..ea7e17b 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -122,6 +122,12 @@ static int fsl_ehci_drv_probe(struct platform_device *pdev)
>  		tmp |= 0x4;
>  		iowrite32be(tmp, hcd->regs + FSL_SOC_USB_CTRL);
>  	}
> +
> +	/* Set USB_EN bit to select ULPI phy for USB controller version 2.5 */
> +	if (pdata->controller_ver == FSL_USB_VER_2_5 &&
> +		pdata->phy_mode == FSL_USB2_PHY_ULPI)

Incorrect indentation of the continuation line.

Alan Stern

> +		iowrite32be(USB_CTRL_USB_EN, hcd->regs + FSL_SOC_USB_CTRL);
> +
>  	/*
>  	 * Enable UTMI phy and program PTS field in UTMI mode before asserting
>  	 * controller reset for USB Controller version 2.5
>