Re: [v6 2/3] drm/msm/dpu: Integrate interconnect API in MDSS

From: Evan Green
Date: Wed Jan 23 2019 - 15:18:02 EST


On Tue, Jan 22, 2019 at 7:43 PM Jayant Shekhar <jshekhar@xxxxxxxxxxxxxx> wrote:
>
> The interconnect framework is designed to provide a
> standard kernel interface to control the settings of
> the interconnects on a SoC.
>
> The interconnect API uses a consumer/provider-based model,
> where the providers are the interconnect buses and the
> consumers could be various drivers.
>
> MDSS is one of the interconnect consumers which uses the
> interconnect APIs to get the path between endpoints and
> set its bandwidth requirement for the given interconnected
> path.
>
> Changes in v2:
> - Remove error log and unnecessary check (Jordan Crouse)
>
> Changes in v3:
> - Code clean involving variable name change, removal
> of extra paranthesis and variables (Matthias Kaehlcke)
>
> Changes in v4:
> - Add comments, spacings, tabs, proper port name
> and icc macro (Georgi Djakov)
>
> Changes in v5:
> - Commit text and parenthesis alignment (Georgi Djakov)
>
> Changes in v6:
> - Change to new icc_set API's (Doug Anderson)
>
> Signed-off-by: Sravanthi Kollukuduru1 <skolluku@xxxxxxxxxxxxxx>

...weird that there's a 1 in your name.

> Signed-off-by: Jayant Shekhar <jshekhar@xxxxxxxxxxxxxx>

Reviewed-by: Evan Green <evgreen@xxxxxxxxxxxx>