Re: [PATCH] iommu/amd: Fix IOMMU page flush when detach all devices from a domain

From: Suthikulpanit, Suravee
Date: Wed Jan 23 2019 - 22:25:26 EST


Joerg,

On 1/23/19 2:56 PM, joro@xxxxxxxxxx wrote:
> Hi Suravee,
>
> On Tue, Jan 22, 2019 at 03:53:18PM +0000, Suthikulpanit, Suravee wrote:
>> Thanks for the detail. Alright then, let's just go with the version you
>> sent on 1/16/19. Do you want me to resend V3 with that changes, or
>> would you be taking care of that?
>
> Please send me a v3 based on the diff I sent last week. Also add a
> separate patch which adds the missing dte flush for the alias entry.
>
> Thanks,
>
> Joerg
>

Actually, I just noticed that device_flush_dte() has already handled flushing the DTE
for alias device as well. Please see the link below.

https://elixir.bootlin.com/linux/latest/source/drivers/iommu/amd_iommu.c#L1219

So, we don't need to call device_flush_dte() for alias device in do_detach().

Regards,
Suravee