Re: [PATCH] blk-mq: fix the cmd_flag_name array

[Jeff Moyer]

Jianchao Wang <jianchao.w.wang@xxxxxxxxxx> writes:

> Swap REQ_NOWAIT and REQ_NOUNMAP and add REQ_HIPRI.
>
> Signed-off-by: Jianchao Wang <jianchao.w.wang@xxxxxxxxxx>
> ---
>  block/blk-mq-debugfs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
> index 90d6876..f812083 100644
> --- a/block/blk-mq-debugfs.c
> +++ b/block/blk-mq-debugfs.c
> @@ -308,8 +308,9 @@ static const char *const cmd_flag_name[] = {
>  	CMD_FLAG_NAME(PREFLUSH),
>  	CMD_FLAG_NAME(RAHEAD),
>  	CMD_FLAG_NAME(BACKGROUND),
> -	CMD_FLAG_NAME(NOUNMAP),
>  	CMD_FLAG_NAME(NOWAIT),
> +	CMD_FLAG_NAME(NOUNMAP),
> +	CMD_FLAG_NAME(HIPRI),
>  };
>  #undef CMD_FLAG_NAME

Acked-by: Jeff Moyer <jmoyer@xxxxxxxxxx>

You might consider also adding a comment above the req_flag_bits enum
noting that modifications also need to be propagated to cmd_flag_name.